Re: [PATCH 1/3] ASoC: mediatek: mt2701: Use devm_clk_get_optional() for audio_mrgif_pd
Cezary Rojewski <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.mediatek |
|---|---|
| Message-ID | <[email protected]> |
On 8/18/2026 1:02 PM, Bui Duc Phuc wrote: >>> Propagate other errors to the caller. >> >> What does that mean? Did the functional path change? >> > > Previously, the code only returned an error for -EPROBE_DEFER and > ignored other errors. > After switching to devm_clk_get_optional(), all other errors are > propagated to the caller as well. > > Regarding the functional path, I don't think it changes on platforms > where the clock is present. > The change only allows platforms without this optional clock to > continue probing. >> This should be part of a mediatek-patch-series with a cover letter. >> Yeah, the mt6797 changes should be here too. > > Currently, the MediaTek ASoC drivers are split into multiple groups by SoC. > I am handling them one group at a time to make the review easier. > > I will send each group once it is completed, rather than waiting for the entire > MediaTek cleanup, which would take quite a long time. A single series > covering all > MediaTek SoCs would also be very long and harder to follow, > especially if changes are requested during review. > > I hope this approach works for you. Thanks for the explanations. I see only benefits from these changes. Reviewed-by: Cezary Rojewski <[email protected]>