Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 19, 2026 at 11:04:26AM +0530, Niranjan H Y wrote:
> + /* SA */
> + {TAC_VOLUME_REG(SA, FU21, LEFT), 0x9c00},
> + {TAC_VOLUME_REG(SA, FU21, RIGHT), 0x9c00},
> + {TAC_GAIN_REG(SA, FU23, LEFT), 0x0},
> + {TAC_GAIN_REG(SA, FU23, RIGHT), 0x0},
> + {TAC_MUTE_REG(SA, FU21, LEFT), 0x1},
> + {TAC_MUTE_REG(SA, FU21, RIGHT), 0x1},
> + {TAC_MUTE_REG(SA, FU23, LEFT), 0x1},
> + {TAC_MUTE_REG(SA, FU23, RIGHT), 0x1},
Did you check the sorting of the table here?
> - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_LEFT), 0),
> - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_RIGHT), 0),
The new macros use _CHANEL_VOLUME and _MASTER_GAIN, there's none using
_CHANNEL_GAIN?
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqFs7UACgkQJNaLcl1U h9DPtwf/fOKVKlF9w1pD+LKM98ZoqGVfXAj8lgmCLVU8FJEmFXUNXOZB4nJIM8gD a8G1I0HLr8rb5M5WETEdWnO2vDQZs24idnm2uFAdNXwshhap0UeizlAZh7XiZgUt ItglPUedBitxBsZi7+i74AHIfATyUpSf0npJ79EuVNQA4fo+OvNtL0rHTsMVZf8N X1+vccpf683z2S3+dRNtWLX/bokGWWPYFqfKLHEEntARQZ2Bh0jwQbpi5M7gOqXt /ZYMyzMakDPKD6yQ1euRPsmtutXXzD9s3MzftFfrcm2TIxlsUz2tj6fK+IzHBrZ1 jKKusD2bn0kfcPwcizgwVYPxRMpuBw== =9qM+ -----END PGP SIGNATURE-----