Re: [PATCH] ALSA: hda/conexant: Set mic pin VREF to 0x24 on headset mic plug

Takashi Iwai <[email protected]>
Newsgroups gmane.linux.sound,gmane.linux.kernel
Message-ID <[email protected]>
On Tue, 25 Aug 2026 11:13:03 +0200,
songxiebing wrote:
> 
> Hi Takashi,
> 
> 0x19 is configured as a mic pin, in cx_update_headset_mic_vref, it
> executes cx_process_headset_plugin only after confirming that a mic
> present is detected. A 4-pole headset is detected as either CTIA or
> OMTP and sets 0x24, but the 3-pole mic case is not handled, so a
> setting of 0x24 is added here.

OK, then you'd need to explain more in the patch description.
It implies that the patch corrects the debug output, too.

And, this also opens another door: why do we read those registers at
all?  Now you always set the pin control 0x24 no matter what the
connection type is.  So the whole headset type detection becomes
practically moot; it's used only for showing a debug print.


thanks,

Takashi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.