Re: [PATCH 0/2] Add larger page size support for USB audio offload path

On 8/26/26 13:25, Michal Pecio wrote:
> On Wed, 26 Aug 2026 00:50:53 -0700, Wesley Cheng wrote:
>> Thanks for this suggestion.  I think it actually makes the overall
>> design a lot better.  So now that the sideband driver has its own
>> segment pool (per sideband instance), we expect that any page
>> allocations done from this pool is technically owned by the audio
>> DSP.  This allows us to still utilize 4k ring segments, while mapping
>> the entire 16k page, so it helps conserve/optimize the memory
>> allocations.  I will do a bit more testing and review before
>> submitting a new revision w/ these changes.
> 
> The part about memory being "owned by the audio DSP" made me wonder
> if it would be helpful to let offload drivers allocate their own memory
> and then just dma_map() it for the xHC. No new rings would be allocated
> for offloaded endpoints when they are enabled, we would point Endpoint
> Context of the xHC to the sideband ring and leave ep->ring as NULL.
> 
> Offload drivers would have full control over memory allocation - size,
> number of segments (it seems that qc-usb-audio only uses one out of two
> allocated by xhci-hcd), alignment, anything else.
> 
> It would become impossible to offload an endpoint which is already
> enabled, but is this an issue for anyone?
> 
> NULL ep->ring will cause oopses/panics when somebody submits URBs to
> offloaded endpoints, but I think it wouldn't be a problem otherwise.
> 
I have similar thoughts.

One idea would be to basically let sideband allocate the entire ring and set
ep->new_ring early. This would tell xhci_endpoint_init() that a ring exists and
a new one should not be allocated.

xhci ring allocation would need some refactoring to create helpers for sideband
to allocate and initialize all the other parts of the ring.

This is something that VTIO (xhci spec section 4.25) would also need.
There an endpoint can be handed over to a secondary DMA ID (second, new PCI BDF),
that the normal xhci driver can be excluded from  with iommu.

VTIO use case is something like trusted VM accessing a secure usb storage device,
preventing regular OS running the xhci driver in another VM from touching it.

The secure VM needs to allocate and map the ring to this secondary PCI BDF

Thanks
Mathias