Re: [PATCH v4 0/2] ASoC: Intel: Add Lenovo Yoga Book RT5677 support
Yauhen Kharuzhy <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.sound |
|---|---|
| Message-ID | <CAKWEGV667AyGDpz-mJn3phTOjKZeVTC+of0Zx_OUZr4H3+_jxA@mail.gmail.com> |
Hi Maurizio, I am glad to see my (a bit abandoned) work to have YB1-X9* support in mainline be continued but please don't drop my ownership for patches when using them. Use Co-developed-by: to mention me as co-developer and keep my Signed-off-by: tags. For reference, my WiP v4 tree is here: https://github.com/jekhor/yogabook-linux-kernel/commits/b4/asoc-yogabook-v4/ чт, 27 авг. 2026 г. в 10:25, Maurizio Casciano <[email protected]>: > > The Lenovo Yoga Book YB1-X91F/L uses a Cherry Trail SSP2 link with an > RT5677 codec and a TS3A227E headset detector. Its amplifiers and > headphone path also require board-specific GPIO sequencing. > > Add a generic Cherry Trail RT5677 machine driver and match the Yoga Book > ACPI codec ID. The machine entry supports both the legacy SST firmware > and the separately maintained SOF IPC3 topology. > > This continues Yauhen Kharuzhy's v3 work and supersedes my RFC series. > The driver retains Yauhen's copyright and links to both his original > implementation and the v3 posting. > > Changes since v3 and the RFC: > > - rename the driver, file and Kconfig symbol from Yoga Book-specific > names to generic Cherry Trail RT5677 names; > - clone the card, DAI links and link components per device instead of > mutating global templates; > - allocate the headset jack separately with the device lifetime; > - unwind MCLK enablement on PLL or sysclk setup failures; > - document the codec ASRC clock selections; > - add the complete SST and SOF machine entry once, reducing the series > from three ASoC patches to two; and > - carry forward Yauhen's copyright and provenance links. > > The series is based on ASoC for-next at 8a070652d919. Both touched C > files passed sparse 0.6.5-rc1. Strict checkpatch reports no errors; its > only warning is the generic new-file MAINTAINERS prompt, while the > existing sound/soc/intel/ entry already covers the new driver. A clean > 20-job bindeb-pkg build completed successfully. > > Runtime testing used an integration kernel containing these exact v4 > sources on a Lenovo Yoga Book YB1-X91L. It used the stock signed > intel/sof/sof-cht.ri firmware, version 2.2.0-57864, and the separately > maintained sof-cht-rt5677.tplg topology. The following passed: > > - UCM Speaker1 and Mic1 route enablement; > - PCM0 playback and capture at 48 kHz stereo in S16_LE, S24_LE and > S32_LE formats; > - PCM1 deep-buffer playback at 48 kHz stereo in S32_LE format; > - a bounded routed speaker tone and a non-empty three-second Mic1 > capture; and > - PipeWire playback and capture with advancing PCM pointers and clean > PCM closure after each stream. > > The GNOME Settings speaker and microphone tests also passed physical > verification. No SOF, IPC, XRUN or ASoC errors were logged during those > tests. The SOF topology source is maintained separately at: > > https://github.com/Yoga-Book/Yoga-Book-Sound-Open-Firmware/commits/feature/cht-rt5677-topology2-ipc3/ > > Maurizio Casciano (2): > ASoC: Intel: Add Cherry Trail RT5677 machine driver > ASoC: Intel: cht: Add Yoga Book RT5677 machine entry > > sound/soc/intel/boards/Kconfig | 14 + > sound/soc/intel/boards/Makefile | 2 + > sound/soc/intel/boards/cht_rt5677.c | 611 ++++++++++++++++++ > .../intel/common/soc-acpi-intel-cht-match.c | 8 + > 4 files changed, 635 insertions(+) > create mode 100644 sound/soc/intel/boards/cht_rt5677.c > > > base-commit: 8a070652d9194babdd35bf7cbd2c6722b441e8f4 > -- > 2.53.0 -- Yauhen Kharuzhy