Re: [PATCH v2 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 27, 2026 at 02:58:04PM +0700, Bui Duc Phuc wrote: > To be honest, after looking at the code for other MediaTek SoCs, I found quite > a few logic issues and inconsistent clock handling. This, along with > the git log history, > makes me wonder whether these code paths were ever properly tested on > real hardware. > Therefore, I have stopped at mt8186 for now. There's a lot of code there with shaky error handling; probably the default case works but things blow up relatively easily on error.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqQZa0ACgkQJNaLcl1U h9DUGwf+MCKXjmklPUUS4YqdH7aXXG4NE645E1C5lIakFBlUZ2EMKk7d0PfJyYJ8 1k50GnIm/Ud5wuZAvf5TWmKCRxtOHlOO3mK46E6jgJDVSEYu8D5G5hJGUoPuZDEF A/V6u4gDYz+UbUiuNEGgcUJAAxcAY0n5vQzDvrZgv+PKaxGdOlTL5j1BzZtX+UlD IDiuE6SkNZQ6MiSeAU/zyw5RLZES6NX3qliToDQnWYNcyWKUl8fdgVkAJWD75jAo 85rJGgqvAPd6kQg3qTf43+PgBovSgwE/oZg1EEyUZrEQpZ2r79S/cFZHfpFz/TV+ DRCLEIOXjwDCmSO5jYZOQXTCLRg4YA== =UBIx -----END PGP SIGNATURE-----