Re: [PATCH 03/20] ASoC: cs35l56: Propagate register restore errors from runtime resume

On Fri, Aug 28, 2026 at 12:55:58PM +0100, Richard Fitzgerald wrote:
> On 28/08/2026 12:33 pm, Pengpeng Hou wrote:
> > cs35l56_runtime_resume_common() checks firmware wake and mailbox errors
> > but ignores the BOOT_DONE read and register-cache replay.  A failed read
> > also leaves val undefined before the BOOT_DONE test.

> for context (as the context is missing in this patch), the code
> immediately above this already communicated with the device, with
> error checks, to determine that (a) the driver can read/write registers
> and (b) the device reads back a valid booted state. So we already know
> communication is good.

Yeah, the reason we often omit I/O error checking is that it's very
unlikely we'll see errors mid run, and if we do the chances of there
being anything constructive we can do about it are generally quite low.
Usually the bus will already log about things.  In theory we should
check, but it's not normally actually important.

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqRgq4ACgkQJNaLcl1U
h9Dp+gf9FacvM9JyMdlC0gDqBfljv7IOk+g8ypEZTPSZyo+CCoa8tK+D8p+k6S2s
MjSmprbSgozwXu3HbymAWlsEu1kVTyzx44nx5O8AsCpf6EFiljw6EWN1VakfvrQN
+otjF2TuyYzdW9ZXTmuQ502pTuyP6zYjqMw7lastSOAilkNhefnt5dikoRdyqQBB
fzt3HhqS4/r6M/6BhF/OUfUxhaP8DOjWOWmAPbTaUxrTt0uJgz6AApR1ruOgSvlJ
oThobxcodV/iRaIoHlJJNWdRDPLjTxvp6mKIfY5TmENvjmhuF6Uf38nt3TfZLPJu
e9RmB+il3svBp6UxlfuFyCRVu0t5YQ==
=W1Zu
-----END PGP SIGNATURE-----