Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding
Harendra Gautam <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.arm.msm,gmane.linux.drivers.devicetree |
|---|---|
| Message-ID | <CAC-tS8BjRPjcFYMjuvyB-9uJkYB=rNkTUtDq9jF6EzgjKfb_qQ@mail.gmail.com> |
> >> Srini, could you please confirm if adding QAIF DAIs to > >> qcom,q6dsp-lpass-ports.h is acceptable given that it increases > >> LPASS_MAX_PORT by 56 (from 149 to 205), which indirectly grows > >> multiple arrays sized by AFE_PORT_MAX and APM_PORT_MAX in other > > > > BTW, the dai ids are already added by Prasad > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h?h=next-20260827#n240 > > > > > > You should use them. > > Correction, he only added QAIF clk ids, not the dai ids, Not sure why > dai ids are missing. > > That also raises question on how did Prasad test it without the QAIF dai > ids. These IDs appear to have been introduced for QAIF interface clock support in PRM SPF for DSP solution. Starting with HAWI, QAIF has been in use. > > > --srini > > > > to your question about increase in size, yes, this is know issue, i have > > some changes to send which will remove the need of this static array > > which should fix the concerns. > > > > But for now all the hardware dai ids for qualcomm SoCs should be in a > > single place irrespective of dsp or non dsp solution. > > Understood. I will add QAIF DAI IDs in qcom,q6dsp-lpass-ports.h in the next version. -Harendra