Re: update ibus to 1.5.1

On Fri, Feb 8, 2013 at 1:47 AM, Fuminobu TAKEYAMA <[email protected]> wrote:
> Hi,
>
> I looked the patch and read this thread:
> https://bugzilla.gnome.org/show_bug.cgi?id=641531
>
> Now, I understand ibus's status icon have been hard coded in GNOME shell
> also in GNOME 3.4.
>
>
>
>> You might like to port the statusIconDispatcher in gnome-shell 3.4 to
>> 3.6, which has been deleted in 3.6, to work ibus 1.4 and gnome-shell:
>
> The code itself exists in notificationDaemon.js but now it requires ibus
> 1.5?
> I found "JS LOG: IBus version is too old" in session.log on 12.3.

AFAIR, it still might need a patch but actually I have never tested
this way since I use ibus 1.5 for gnome-shell 3.6.

>
> See bottom of this mail.
>
>
> What can we do in a few weeks?
> - Hack GNOME shell to support ibus 1.4 or implement a new shell extension
> - Hack ibus to enable its normal tray icon shown in the bottom right
>   * this is disabled to avoid two status icons
> - Ask users to enable ibus's tool bar
>
> - Fix problems with ibus 1.5, our IM launcher and implement
> ibus-branding-opensuse
>   for compatibility of key bindings
>
>
> Hillwood,
> Have you reported this issue in Bugzilla?
>
>
> ======
> Here is a part of notificationDaemon.js in 3.6.
> If wmClass is not in STANDARD_..., then do nothing?

Right. Only if the WM_CLASS is registered in gnome-shell, the gtk
status icon could be shown. And ibus's WM_CLASS is 'ibus-ui-gtk'.
https://github.com/ibus/ibus/commit/5ef29602141945ed1255662576c2e8194af78325

> a bit strange to me...
>
>> const STANDARD_TRAY_ICON_IMPLEMENTATIONS = {
>> /* (snip) */
>>     'ibus-ui-gtk': 'input-method'
>> };
>
>
>> if
>> _onTrayIconAdded: function(o, icon) {
>>   let wmClass = icon.wm_class ? icon.wm_class.toLowerCase() : '';
>>   if (STANDARD_TRAY_ICON_IMPLEMENTATIONS[wmClass] !== undefined)
>>     return;
>>
>>   let source = this._getSource(icon.title || icon.wm_class ||
>> C_("program", "Unknown"), icon.pid, null, null, icon);
>> },
>
>
> On the other hand in statusIconDispatcher.js in 3.4:
>
>> _onTrayIconAdded: function(o, icon) {
>>     let wmClass = (icon.wm_class || 'unknown').toLowerCase();
>>     let role = STANDARD_TRAY_ICON_IMPLEMENTATIONS[wmClass];
>>     if (role)
>>         this.emit('status-icon-added', icon, role);
>>     else
>>         this.emit('message-icon-added', icon);
>> },
>
>
>
> Fuminobu TAKEYAMA
>
>
> (2013/01/31 17:04), Takao Fujiwara wrote:
>>
>> On Thu, Jan 31, 2013 at 4:45 PM, 逍遥游 <[email protected]> wrote:
>>>
>>> We have disabled integrate in openSUSE,  so this method is not valid.
>>
>>
>> I have no idea... gnome-settings-daemon switches ibus engines in
>> gnome-shell 3.6.
>> You might like to port the statusIconDispatcher in gnome-shell 3.4 to
>> 3.6, which has been deleted in 3.6, to work ibus 1.4 and gnome-shell:
>>
>> http://git.gnome.org/browse/gnome-shell/commit/?id=dfb97c1ed77aabd6c25c3a398920feb715d72f60
>>
>>>
>>>
>>> 2013/1/31 Takao Fujiwara <[email protected]>
>>>>
>>>>
>>>> On Thu, Jan 31, 2013 at 4:25 PM, Hillwood Yang <[email protected]>
>>>> wrote:
>>>>>
>>>>> was installed. If IBus-1.0.typelib 1.5.x was installed, Gnome-shell
>>>>> would force enable gjs ui to instead ibus's native gtk3 panel ui, and
>>>>> prevented ibus responded shortcut keys, so that we can't use Ctrl+Space
>>>>> to switch input engine. This problem must cause by the Gnome 3.6. Can
>>>>
>>>>
>>>> Use gnome-control-center to set the trigger keys. ibus is now
>>>> integrated in gnome.
>>>>
>>>> fujiwara
>>>
>>>
>>>
>
-- 
To unsubscribe, e-mail: [email protected]
To contact the owner, e-mail: [email protected]