[2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue()
Adrian Bunk <[email protected]> Wed, 2 Nov 2005 10:10:59 +0100
| Newsgroups | gmane.linux.kernel,gmane.linux.suse.packet-writing |
|---|---|
| Message-ID | <[email protected]> |
Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com). The function pkt_iosched_process_queue makes a call to bdev_get_queue and stores the result but never uses it, so it looks like it can be safely removed. From: Gabriel A. Devenyi <[email protected]> Signed-off-by: Gabriel A. Devenyi <[email protected]> Signed-off-by: Adrian Bunk <[email protected]> --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -501,14 +501,11 @@ static void pkt_queue_bio(struct pktcdvd */ static void pkt_iosched_process_queue(struct pktcdvd_device *pd) { - request_queue_t *q; if (atomic_read(&pd->iosched.attention) == 0) return; atomic_set(&pd->iosched.attention, 0); - q = bdev_get_queue(pd->bdev); - for (;;) { struct bio *bio; int reads_queued, writes_queued;