Re: 'kvm_rng_device' is not a valid device model name

Dinar Valeev <[email protected]> writes:

> Hi,
> We have Power workers failing constantly with 'kvm_rng_device' is not
> a valid device model name, this is a result of part of qemu command:
> -object rng-random,filename=/dev/hwrng,id=rng0 -device kv
> m_rng_device,rng=rng0
>
> I wonder why $kvm_rng_device [1] is not expanded here?
>
> [1] https://github.com/openSUSE/obs-build/blob/master/build-vm-kvm#L196

This is not the file that is distributed by backend-opensuse.  The real
file has the following difference:

@@ -189,11 +189,8 @@
         if test -c /dev/hwrng &&
            test -f /sys/class/misc/hw_random/rng_current &&
            test "$(cat /sys/class/misc/hw_random/rng_current)" != none; then
-            rng_dev="/dev/hwrng"
-        else
-            rng_dev="/dev/random"
+            kvm_options="$kvm_options -object rng-random,filename=/dev/hwrng,id=rng0 -device kvm_rng_device,rng=rng0"
         fi
-        kvm_options="$kvm_options -object rng-random,filename=$rng_dev,id=rng0 -device $kvm_rng_device,rng=rng0"
     fi
 }
 

Andreas.

-- 
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-- 
To unsubscribe, e-mail: [email protected]
To contact the owner, e-mail: [email protected]