Re: Up to date trees.

Hi.

On 15/02/12 20:33, Andrey Rahmatullin wrote:
> On Mon, Feb 13, 2012 at 03:13:35PM +0600, Andrey Rahmatullin wrote:
>> Yesterday I've got an OOPS right after suspend start. Unfortunately
>> pause_on_oops ended just at the moment I made the photo so the stack is
>> not very readable but looks like the stack of the second OOPS contains the
>> first one (below invalid_op) so I made a photo of it too:
>>
>> http://img-eburg.fotki.yandex.ru/get/5507/5627162.58/0_5f513_817cc797_XXXL
>> http://img-eburg.fotki.yandex.ru/get/5009/5627162.58/0_5f514_2359300d_XXXL
> This one is better:
> http://img-fotki.yandex.ru/get/58191/5627162.58/0_5f591_5de971d4_XXXL
> This time it crashed in the middle of writing.
> 
> The crash site is
> 
>   if (unlikely(trap_non_toi_io))
>       BUG_ON(!(bio->bi_rw & REQ_TOI));

Please try the attached patch. Since it's a timer function that's
causing the issue, it won't necessarily show up on the first try.

Regards,

Nigel

-- 
Evolution (n): A hypothetical process whereby improbable
events occur with alarming frequency, order arises from chaos, and
no one is given credit.

_______________________________________________
TuxOnIce-devel mailing list
[email protected]
http://lists.tuxonice.net/listinfo/tuxonice-devel

diff --git a/fs/xfs/xfs_sync.c b/fs/xfs/xfs_sync.c
index 40b75ee..9ee1b2f 100644
--- a/fs/xfs/xfs_sync.c
+++ b/fs/xfs/xfs_sync.c
@@ -496,7 +496,7 @@ xfs_sync_worker(
 					struct xfs_mount, m_sync_work);
 	int		error;
 
-	if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
+	if (!(mp->m_flags & XFS_MOUNT_RDONLY) && !atomic_read(&system_freezing_cnt)) {
 		/* dgc: errors ignored here */
 		if (mp->m_super->s_frozen == SB_UNFROZEN &&
 		    xfs_log_need_covered(mp))