Re: Up to date trees.

On Thu, Feb 16, 2012 at 08:21:21AM +1100, Nigel Cunningham wrote:
> >> Yesterday I've got an OOPS right after suspend start. Unfortunately
> >> pause_on_oops ended just at the moment I made the photo so the stack is
> >> not very readable but looks like the stack of the second OOPS contains the
> >> first one (below invalid_op) so I made a photo of it too:
> >>
> >> http://img-eburg.fotki.yandex.ru/get/5507/5627162.58/0_5f513_817cc797_XXXL
> >> http://img-eburg.fotki.yandex.ru/get/5009/5627162.58/0_5f514_2359300d_XXXL
> > This one is better:
> > http://img-fotki.yandex.ru/get/58191/5627162.58/0_5f591_5de971d4_XXXL
> > This time it crashed in the middle of writing.
> > 
> > The crash site is
> > 
> >   if (unlikely(trap_non_toi_io))
> >       BUG_ON(!(bio->bi_rw & REQ_TOI));
> 
> Please try the attached patch. Since it's a timer function that's
> causing the issue, it won't necessarily show up on the first try.
OK, it is safe to assume that this patch indeed fixed that OOPSes.

> diff --git a/fs/xfs/xfs_sync.c b/fs/xfs/xfs_sync.c
> index 40b75ee..9ee1b2f 100644
> --- a/fs/xfs/xfs_sync.c
> +++ b/fs/xfs/xfs_sync.c
> @@ -496,7 +496,7 @@ xfs_sync_worker(
>  					struct xfs_mount, m_sync_work);
>  	int		error;
>  
> -	if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
> +	if (!(mp->m_flags & XFS_MOUNT_RDONLY) && !atomic_read(&system_freezing_cnt)) {
>  		/* dgc: errors ignored here */
>  		if (mp->m_super->s_frozen == SB_UNFROZEN &&
>  		    xfs_log_need_covered(mp))


-- 
WBR, wRAR

_______________________________________________
TuxOnIce-devel mailing list
[email protected]
http://lists.tuxonice.net/listinfo/tuxonice-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPagabAAoJEDNi9wMaSZLh/RoP/Rn2GKP5Xtp2fCUs7JdKHD7j
um1AWYwG/4uJlGFewDFtAdP5r24ZmnXdlQxC5NyHO4pEHrnOuTpdudLJlbgDpQKo
p2V7B2NMUw99uiERaKoTPjtDaT2U3yiKAV5jZP9X+c2B0jhUyMRwyxKUSpoevG52
Q7h5evfS+tfKzfgJ5o70UtClgncDNilYrlJK0Le4ZbqCu4fFqpMDDHIRZf3D1AGR
4uNm4+wWEkIUjWKi5DWexkglm4HV5TXMX73qS04siYjrvZfPvZXwz+gpOIhzR4Dj
VmM151iifsPV2RvwXRMXs0b1xOqD4Hio5NKaIYeCdOh6jS/lT2+tHJYEdWl/04Z0
FoG5lFRaGFMoLNzcRcpOeKrVheRmSTMWbjOlE638EqfuhkE6qDMwH6RNoHF1P8Hc
M0Axf+2cvlP+fF0QY1IEpUMUVlpq37ygYx6wguZsSr5x1ELUJnaXbiy8dvzDHTKw
65BCqRNFy6+98qkc/aoShAOP3mgFn54OruD1le/fcb+NsN+RdYv2zisBET8StPzb
+DG+ynyEhK0vx9VybzNKdgAuG0GuYSkhMNtzzCZOfdZho5ii8ABibrc3Lbq84api
82ycksn/mKm6KGsBZN0lEmShfLiKRyaCBmLlw7maEdYuuyh/QTZTPaWeic4B94rH
95Ut4QKs/do+U3hIx0Ci
=qlA4
-----END PGP SIGNATURE-----