Re: memory_bm_test_bit_index() need 3 args

Hi Julien.

On 04/06/12 10:08, Julien DÉCHARNE wrote:
> Hi,
>
> I try to compile branch tuxonice-3.3 from github (last commit Friday 1 Jun.)
> I believe there's a typo in include/linux/tuxonice.h, because with
> CONFIG_TOI_ZRAM_SUPPORT defined, macro PagePrecompressed(page, cpu) expand as :
>
> (precompressed_map ? \
> 	memory_bm_test_bit_index(precompressed_map, page_to_pfn(page)) : 0, cpu)
>
> This seems more correct :
>
> (precompressed_map ? \
> 	memory_bm_test_bit_index(precompressed_map, page_to_pfn(page), cpu) : 0)
>
>
> ... At least as far I understand. Anyway branch tuxonice-head won't compile with
> CONFIG_TOI_ZRAM_SUPPORT defined (first error is too few arguments for
> memory_bm_test_bit_index()). On the other hand, without this typo branch
> tuxonice-3.3 compile, boot and run. I have cycled suspend/resume without any
> problems - so far.
>
> By the way, thanks for your work Nigel, and please continue !
Thanks!

Sorry for not picking that up. Your correction is bang on. In 3.4, there 
are further changes that I need to work through, so I'll also address 
them before committing a fix.

Regards,

Nigel