Re: TOI fails with btrfs

This is a multi-part message in MIME format.
--------------090105000409020206010601
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Oleksandr.

Please find attached a patch that should help. I would like to get your V=
M if it's a reasonable size (I'm not on the fastest connection), as I'd l=
ike to see how the btrfs thread is managing to get to run - it looks to m=
e like it should be properly frozen.

Regards,

Nigel

On 24/09/15 20:35, Oleksandr Natalenko wrote:
> OK, looking forward to some results.
>
> Meanwhile, I've prepared VM for VirtualBox with similar disk layout and=
 custom TOI-enabled kernel, and it fails as well in the same manner. So, =
I expect it to be generic, non-hardware issue. Also, it would be much eas=
ier for me to test changes without being afraid of real data corruption.
>
> Please, let me know if you need such a VM as well.
>
> 23.09.2015 00:16, Nigel Cunningham =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=
=D0=B2:
>> Hi Oleksandr.
>>
>> Just a quick note to let you know I'm looking at it.
>>
>> Sorry for the delay in replying.
>>
>> Nigel
>>
>> On 20/09/15 07:13, Oleksandr Natalenko wrote:
>>> Correction: the right kernel config is here: [1]
>>>
>>> [1] https://gist.github.com/405afe6e4dea4640baed
>>>
>>> On Sunday, September 20, 2015 12:09:01 AM Oleksandr Natalenko wrote:
>>>> Hello, Nigel.
>>>>
>>>> I've encountered hibernation issues while using TOI and btrfs.
>>>>
>>>> The problem is that TOI refuses to work properly with btrfs. I've re=
produced
>>>> the following stacktraces reliably on 2 machines that use similar di=
sk
>>>> layout and same kernel version (4.2).
>>>>
>>>> First stacktrace [1] occurs in block/blk-core.c:1994. That BUG_ON() =
shows us
>>>> that there is 3rd-party bio activity while hibernating. The second
>>>> stacktrace [2] (it occurs immediately after first stacktrace) shows =
us that
>>>> there is some btrfs activity happening. So, on may conclude that btr=
fs is
>>>> not frozen properly by TOI.
>>>>
>>>> Also, I've noticed that while userui helper reports writing progress=
 on
>>>> screen (I've set console debug level to 1), in fact nothing is being
>>>> written to disk (I see no HDD LED activity during TOI writing operat=
ion).
>>>>
>>>> Here is my disk layout [3]. /dev/mapper/system-root is btrfs partiti=
on with
>>>> subvolumes [4].
>>>>
>>>> Also here is my kernel config [5]. No additional patches were applie=
d except
>>>> TOI from git tree (4.2 branch).
>>>>
>>>> How that issue could be fixed? Feel free asking me for any additiona=
l info.
>>>>
>>>> Regards,
>>>>   post-factum
>>>>
>>>> --=20
>>>>
>>>> [1] http://i.piccy.info/
>>>> i9/99adc1e49adcbea1641cc7cc334e4fd4/1442696236/723905/951663/toi_fai=
l_1.jpg
>>>>
>>>> [2] http://i.piccy.info/i9/12ddd0e30317965a9713e5250209f7af/
>>>> 1442696258/666221/951663/toi_fail_2.jpg
>>>>
>>>> [3] https://gist.github.com/abaaeb5b26f338e978a6
>>>>
>>>> [4] https://gist.github.com/b22a4eca266a4958b0be
>>>>
>>>> [5] https://gist.github.com/cc8ef85d394efe5a7aab
>>>> _______________________________________________
>>>> TuxOnIce-devel mailing list
>>>> [email protected]
>>>> http://lists.tuxonice.net/listinfo/tuxonice-devel
> _______________________________________________
> TuxOnIce-devel mailing list
> [email protected]
> http://lists.tuxonice.net/listinfo/tuxonice-devel


--------------090105000409020206010601
Content-Type: text/x-patch;
 name="oleksandr.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="oleksandr.patch"

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 4f5ecbe..f473297 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8105,7 +8105,7 @@ static void md_start_sync(struct work_struct *ws)
  */
 void md_check_recovery(struct mddev *mddev)
 {
-	if (mddev->suspended)
+	if (mddev->suspended || pm_freezing)
 		return;
 
 	if (mddev->bitmap)

--------------090105000409020206010601
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVHV4T25JY2Ut
ZGV2ZWwgbWFpbGluZyBsaXN0ClR1eE9uSWNlLWRldmVsQGxpc3RzLnR1eG9uaWNlLm5ldApodHRw
Oi8vbGlzdHMudHV4b25pY2UubmV0L2xpc3RpbmZvL3R1eG9uaWNlLWRldmVs

--------------090105000409020206010601--