Re: [PATCH] xrexecd-localapp-plugins32.diff

Oliver Grawert wrote:
> hi,
> On Mo, 2008-09-01 at 21:46 -0400, Johnny Robeson wrote:
>> yes, i'd like this script to be available as an optional component in
>> some fashion
>>> Opinions?
>>>
>>  
> i have some points first:
> 
> * if it would be written in a way so it doesnt only work on SuSE ;) 
> ubuntu and debian dont have the directory thats used in this script, we
> use xulrunner so use the xulrunner paths to make the same plugins
> available to *all* browsers apart from (webkit driven) konqueror. 
> 
> * the achitecture check needs a massive cleanup as well matching
> i[3,4,5,6]86 can be done in a cleaner way ...
> 
> * it should have a check if firefox is installed at all on the client
> (looking for the binary or .desktop file) and exit gracefully right at
> the start if not.

Totally agreed with the above.

> 
> * its missing a set -e to properly handle errors :)

I differ on this point.  None of my scripts use set -e and I really 
prefer to write my own error handling.

> 
> * such a script would typically go
> into /usr/share/doc/ltsp-client/examples but the past showed thats not
> really helpful for users i'd probably put it into a firefox-ltsp-client
> package since it hard depends on firefox and directories created by FF.
> 

Do we have one upstream source repository for each tiny one-file add-on, 
or one source repository for a collection of one-file add-ons and that 
gets built into many little sub-packages?

Warren

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net