Re: [patch] LDM Nomad support with local CD/DVD/USB and sound

Vagrant Cascadian <[email protected]>
Newsgroups gmane.linux.terminal-server.devel
Message-ID <[email protected]>
On Sun, Feb 01, 2009 at 11:01:29AM +0530, Jigish Gohil wrote:
> On Thu, Jan 22, 2009 at 9:44 PM, Jigish Gohil <[email protected]> wrote:
> > Please find attached the patch for the support for Nomad[1] in LDM.
 
> Attached is the improved patch incorporating Gadi's suggestions.
> 
> Could we now merge the patch as it does not affect any other part of
> the LDM functioning.

so i've got a few questions...

is it really Nomad specific, or just RDP protocol? it's hard to figure out from
the docs if Nomad is like LTSP (a collection of services and technologies), or
actually a whole new protocol..

why was this mostly implemented in the C code rather than as another (or within
existing) rc.d/X hook(s)?

and a couple critiques...

it seems to pass the password on the commandline- this is generally bad practice security wise...

very minor, but whitespace isn't consistant in some places. i suspect mixed
tabs and spaces..

live well,
  vagrant

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.