Re: [patch] LDM Nomad support with local CD/DVD/USB and sound

On Sat, Feb 14, 2009 at 12:54 AM, Vagrant Cascadian
<[email protected]> wrote:
>
> overall this patch looks good. i tested it with plain rdesktop/xrdp, and it
> seems to basically work, although no support for sound or localapps.  it also
> doesn't seem to respect changing the selected session or language.
>

Localapps cannot work as rdesktop session does not share the same X
root window through which we handle xprop communication.

We didn't see anything in rdesktop command to handle session and language.

> one nice thing is that session resume (ctrl-alt-backspace) worked without any
> special configuration, though i wonder if it wouldn't cause issues if logged in
> from another location?
>

Session persistence is one of the best things about xrdp, it should
not cause any issue logging in from another location as the session is
still running on the server.

> local devices (cdrom/floppy) didn't get unmounted properly for me- maybe
> because of the resume handling.
>
Proper log out would be required for unmounting, as resuming mean the
session is still running on the server.

> i don't know how many of the quirks i encountered aren't present in an
> environment where Nomad patches to rdesktop (and xrdp?) are applied.
>
No patch relating to these issues in nomad.

>> diff -ur a/rc.d/X95-run-x-session b/rc.d/X95-run-x-session
>> +# If nomad is used, just export variables to file else run full Xsession
>> +if boolean_is_true "$LDM_NOMAD"; then
>> +        ssh -S $LDM_SOCKET -l $LDM_USERNAME $LDM_SERVER "echo $MY_SOUND > ~/.ltspvars"
>> +else
>> +        ssh -Y -t -S $LDM_SOCKET -l $LDM_USERNAME $LDM_SERVER "$CLIENT_ENV $MY_LANG $MY_DISP $MY_SOUND $LDM_XSESSION $LDM_SESSION < /dev/null > /dev/null $MY_LOCALDEV"
>> +fi
>
> so it clearly is trying to cache the sound related variables in ~/.ltspvars.
>
> this doesn't seem to happen automatically for me- i'm guessing a genuine nomad
> environment sources this file somehow? does it export these variables as well?
> when i manually sourced and exported the variables, sound worked (though maybe
> a little choppier than usual?) ... and continued to work after
> ctrl-alt-backspace, sitting at the ldm login screen... go resumeable sessions!
> :)
>
> i suspect issues with sound and resumed sessions...
>
>
> we did just go through some trouble to get rid of writing files into the user's
> home dir with LOCAL_APPS_MENU code... so it kind of feels like a regression
> there. it also doesn't clean up ~/.ltspvars on logout.
>

I have no clue how to handle this without creating ~/.ltspvars. We
intend to source this file[1] from /etc/profile.local to export the
variables when user logs in.

Any suggestions/help in implementing this cleanly is welcome :)

> all that said, i think the patch is pretty much ok for merging, although i'd
> really like to see some other way to handle sound variables, as writing files
> to a user's home directory has some unfortunate consequences.
>

As more people start using xrdp server with LTSP may be we can get
some good developer interested in fixing other minor quirks.

Ciao

-J

[1] http://pastebin.com/f23a939b3

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net