breakage in LDM Nomad support

so, in an attempt to fix session selection for Nomad in ldm, the fix applied
completely hangs any attempt to log in using xrdp (0.4.0~dfsg-9) for me.

with this revision (1155) reverted, it works fine for me (although session
selection is still broken), and so i uploaded to debian ldm 2.0.40 with the
patch reverted, but left the code alone in the ldm-trunk bzr branch.

do other folks (on other distros) have the ability to get nomad/xrdp support
working with the current ldm-trunk or 2.0.40?

1155 Ryan Niebur       2009-04-07
      support session selection for nomad

=== modified file 'src/ldm.c'
--- src/ldm.c   2009-03-30 20:44:53 +0000
+++ src/ldm.c   2009-04-08 06:58:05 +0000
@@ -295,7 +295,17 @@

     rc_files("xsession");
     if (ldm.nomad) {
-        command = g_strjoin(" ", "rdesktop", "-z", "-f", "-u", ldm.username, "-p", ldm.password, "-s", ldm.session, " ", ldm.server, NULL);
+        ldminfo *curr_host = NULL;
+        curr_host = g_hash_table_lookup(ldminfo_hash, ldm.server);
+        guint i;
+        for(i = 0; i < g_list_length(curr_host->sessions); i++) {
+            gchar * str = g_list_nth_data(curr_host->sessions, i);
+            if(!g_strcmp0(str, ldm.session)) {
+                break;
+            }
+        }
+        gchar * my_session_name = g_list_nth_data(curr_host->session_names, i);
+        command = g_strjoin(" ", "rdesktop", "-z", "-f", "-u", ldm.username, "-p", ldm.password, "-s", g_shell_quote(my_session_name), " ", ldm.server, NULL);
         ldm.nomadpid = ldm_spawn(command, NULL, NULL, NULL);
         g_free(command);
         g_free(ldm.password);

live well,
  vagrant

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net