Re: LDM Greeter update.

On Tue, 2011-02-08 at 16:19 -0500, [email protected] wrote:
> Hey Stephane,
> 
> I've modified the greeter to use glade instead of the hard coded 
> interface in hopes that it would help people further customize their 
> theme. I've added options to hide some of the menu item's that I didn't 
> want in my environment (language, session, shutdown). It also addresses 
> the issue of the window spreading across multiple screens. I posted the 
> links in #ltsp on freenode but figured that I would email you as well. 
> Vagrantc mentioned that he thought it originally used glade and was 
> changed because of performance issues but I don't believe I experienced 
> any, nor did I find anything related to glade in the change log 
> http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ldm-trunk/changes/ , 
> but perhaps I missed it or was looking in the wrong place. If you think 
> others might find it useful perhaps you can incorporate the changes in 
> later releases? My updates can be found at:
> 
> greeter.c: http://paste2.org/p/1236307
> greeter.glade: http://paste2.org/p/1236315
> greeter.xml: http://paste2.org/p/1236313
> 
> Best Regards
> Matt Janus
> 

Hi,

Thanks for the awesome work. Moving to a glade file would definitely
help people customize the greeter.

Something I noticed is that you seem to have based your changes on a
relatively old version of the greeter and introduce quite a few extra
changes (white spaces, trailing white space, ...) making it hard for us
to review and merge into upstream ldm.

Our current code is available using bzr:
bzr get lp:~ltsp-upstream/ltsp/ldm-trunk

I'd really appreciate it if you could make your changes on top of that
and either send us a patch or even better, a bzr branch of your changes.

If you have a Launchpad account, you can simply, do:
bzr commit -m "Some description"

Every-time you do a major change to the code, then when you're done, do:
bzr push lp:~<username>/ltsp/ldm-trunk-glade

To push your changes to Launchpad so we can easily see what got changed
and merge that into our main branch while still keeping information
about every commit you did.


Once again, thanks for the awesome work and please let us know if you
need any additional information.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb

_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAABCgAGBQJNUqxBAAoJEMY4l01keS1ng34QANc7UVD9YdfnmCogMuh4jEvf
Wq3e90QfWOBCR5qFsF3J9uvFogsidYOiWGW1yR8b2cnM78eU4rw6fAxB2HjmyK2k
SwzrXhsptTmvygNDpCuIPk3cuLMiU0kTAMqWcOLYQCToC3sWmFSIv5PT6zFCQuM9
c1noqG3FCG7HhGVLSKsZZoRQWvcW4nobW/OBN7ZtxfJidLhZRTh8EEcdsAgQbnSG
YgORjWD8X2oTdebNFitlRpje8g1aYNRZVX/kEjsFhPrzbf74e9STv9LlXw6P/LuU
kPxKC+9ui+40++ygg07gG1zvQtid36afUy5pj/6PgdAyxnfparF3XJYtHOZtjzVL
h4l0Rfa7FXUmkLA0o8rKxuLSLNICa/fOPprIfqwMAsZst610UVoawm6j3/sgTTDV
85UsbdNVFove7C8pkI5Arz7J0Jm/JteaRhjrMdqgC/UU0X+JkuPM9HkXyTHWl4sj
tgeU20rW81XufuSIby8d5NhdtQ+dBhKD5pg024xNo5eNLB1RHCtsouywZdSS4nXy
LDQoBivMQnI8O7PZggaM3Z8po53eG51e/hBQVF5d8ZnjzC/iLY7kG4zl8U/euwFB
QMrrXBnCUjtllyBj2wz1kWH3bYP45eYe3OpU4G9Z+HUMITZEfdnYMa8jBaN2Yk1B
avfKOMza7WMt1UUxswA+
=h1D/
-----END PGP SIGNATURE-----