Xsession and LDM_DEFAULT_SESSION thoughts

Thinking about two separate problems...

https://bugzilla.redhat.com/show_bug.cgi?id=451882
I would like to add an option recognized by ldm called 
LDM_DEFAULT_SESSION.  This would be an option for some distros like us 
that do not use alternatives for a default desktop setting.  If the 
option is present, it would run Xsession and the specified 
LDM_DEFAULT_SESSION as the $1 parameter.

This wouldn't risk other distros who do not use it, so this shouldn't be 
controversial.  Any objections if I just do it?

https://bugzilla.redhat.com/show_bug.cgi?id=436912
Currently if a user chooses the non-default session from the LDM menu, 
then it runs that command directly (like startkde or startxfce4) instead 
of passing through the Xsession script.  This is a problem for us 
because Xsession does things like xinput* scripts that setup Input 
Method support.

I would like to change ldm to *always* launch a command like 
gnome-session, startkde or startxfce4 as the $1 parameter of the 
Xsession script.  This is supported on Fedora/RHEL, and Debian/Ubuntu 
are supposed to work as well.

--- src/ldm.c	2008-04-19 18:18:53 +0000
+++ src/ldm.c	2008-06-17 22:59:16 +0000
@@ -304,6 +304,7 @@
      }

      cmd[i++] = ldminfo.session;
+    cmd[i++] = "startkde";

      if (ldminfo.localdev) {
          cmd[i++] = ";";        /* closes bug number 121254 */

You can do a quick and dirty test by patching your ldm and trying it on 
your system.  Replace the string in quotes with a session launcher that 
is different from your current default.  Could all distros please test 
your Xsession script $1 handling and report back?

At least in theory this should be functionally equivalent.  I would like 
to make this the default behavior in ldm if it works for everyone's 
Xsession scripts.

Thoughts?

Warren Togami
[email protected]

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net