Re: [patch 1/1] Removing bashisms

Aruna Balakrishnaiah <[email protected]> Wed, 26 Mar 2014 15:28:16 +0530
Newsgroups gmane.linux.tools.diag.devel
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--===============3305801393423291322==
Content-Type: multipart/alternative;
	boundary="------------010200000803000209020908"

This is a multi-part message in MIME format.
--------------010200000803000209020908
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Acked-by: Aruna Balakrishnaiah<[email protected]>


On Tuesday 25 March 2014 10:05 PM, [email protected] wrote:
> On debian SHELL is by default /bin/sh (dash) whereas rules.mk on fedora relies on a
> /bin/sh being bash it seems. Making it compatible with both
>
> Signed-off-by: Frédéric Bonnard<[email protected]>
> --- a/rules.mk
> +++ b/rules.mk
> @@ -13,9 +13,9 @@
>   # resolves the root directory at which this build is occuring
>   ROOT_DIR =                                              \
>           $(shell                                         \
> -        while [[ `pwd` != "/" ]];                       \
> +        while [ `pwd` != "/" ];                         \
>           do                                              \
> -                if [[ -f `pwd`/$(SPECFILENAME) ]];      \
> +                if [ -f `pwd`/$(SPECFILENAME) ];        \
>                   then                                    \
>                           echo `pwd`;                     \
>                           break;                          \
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> Linux-diag-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/linux-diag-devel


--------------010200000803000209020908
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">
      <pre wrap="">Acked-by: Aruna Balakrishnaiah <a class="moz-txt-link-rfc2396E" href="mailto:[email protected]">&lt;[email protected]&gt;</a></pre>
      <br>
      On Tuesday 25 March 2014 10:05 PM, <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a>
      wrote:<br>
    </div>
    <blockquote cite="mid:[email protected]"
      type="cite">
      <div class="moz-text-plain" wrap="true" graphical-quote="true"
        style="font-family: -moz-fixed; font-size: 12px;"
        lang="x-unicode">
        <pre wrap="">On debian SHELL is by default /bin/sh (dash) whereas rules.mk on fedora relies on a
/bin/sh being bash it seems. Making it compatible with both

Signed-off-by: Frédéric Bonnard <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:[email protected]">&lt;[email protected]&gt;</a>
--- a/rules.mk
+++ b/rules.mk
@@ -13,9 +13,9 @@
 # resolves the root directory at which this build is occuring
 ROOT_DIR =                                              \
         $(shell                                         \
-        while [[ `pwd` != "/" ]];                       \
+        while [ `pwd` != "/" ];                         \
         do                                              \
-                if [[ -f `pwd`/$(SPECFILENAME) ]];      \
+                if [ -f `pwd`/$(SPECFILENAME) ];        \
                 then                                    \
                         echo `pwd`;                     \
                         break;                          \


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://p.sf.net/sfu/13534_NeoTech">http://p.sf.net/sfu/13534_NeoTech</a>
_______________________________________________
Linux-diag-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/linux-diag-devel">https://lists.sourceforge.net/lists/listinfo/linux-diag-devel</a>
</pre>
      </div>
    </blockquote>
    <br>
  </body>
</html>

--------------010200000803000209020908--



--===============3305801393423291322==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
--===============3305801393423291322==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Linux-diag-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-diag-devel

--===============3305801393423291322==--