Re: [PATCH] rtas_errd: Add support for PHB hotplugging via RTAS event

Quoting Vasant Hegde (2015-05-30 11:11:11)
> On 05/28/2015 05:16 AM, Michael Roth wrote:
> > This extends the hotplug hooks in place for PCI/MEM/CPU hotplug to also
> > handle PHB hotplug.
> > 
> > This requires an updated powerpc-utils to work properly, due to the
> 
> Michael,
> 
> Can you specify what version of powerpc-utils required? So that we can update
> the spec file!

Hi Vasant,

The patches are still pending on powerpc-utils-devel. It's mainly just
one patch:

http://sourceforge.net/p/powerpc-utils/mailman/message/34124888/

Without that, drmgr will fail the lookup. Since the current behavior
when recieving a PHB hotplug event (PowerKVM-only atm, not present
on pHyp) is a no-op, I hope maybe that's acceptable?

> 
> 
> > fact that drmgr does not currently handle hotplugging based on DRC
> > index, and instead relies on DRC name strings.
> > 
> > Signed-off-by: Michael Roth <[email protected]>
> 
> Nathan,
>  Can you please Ack this patch?
> 
> > ---
> >  rtas_errd/hotplug.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/rtas_errd/hotplug.c b/rtas_errd/hotplug.c
> > index 91036b2..ad048ae 100644
> > --- a/rtas_errd/hotplug.c
> > +++ b/rtas_errd/hotplug.c
> > @@ -46,6 +46,9 @@ void handle_hotplug_event(struct event *re)
> >                       case RTAS_HP_TYPE_MEMORY:
> >                               drmgr_args[2] = "mem";
> >                                  break;
> > +                     case RTAS_HP_TYPE_PHB:
> > +                             drmgr_args[2] = "phb";
> > +                                break;
> 
> Code looks good .. I assume you have tested this patch!

Yes of course :)

> 
> -Vasant
> 

------------------------------------------------------------------------------