[PATCH] [lsvpd] separate VPD stanzas in lsvpd output

Paul Clarke <[email protected]> Wed, 30 Sep 2015 12:12:48 -0500
Newsgroups gmane.linux.tools.diag.devel
Message-ID <[email protected]>
Output from lsvpd command has no separation between different stanzas,
making interpretation difficult:
--
*VC 5.0
*TM IBM,8246-L2T
*SE IBM,03060606A
*PI IBM,03060606A
*OS Linux 3.10.0-229.el7.ppc64
*FC
*DS System VPD
*RT VSYS
*FG XXSV
*BR S0
*YL U8246.L2T.060606A
*SE 060606A
*TM 8246-L2T
*SU 0004AC194FE8
*VK ipzSeries
*YL U8246.L2T.060606A
*WN C0507606907D
*FV AL770_038
*FC
*DS ibm,compression-v1
*AX ibm,compression-v1
*YL ibm,compression-v1
*FC
*DS ibm,random-v1
*AX ibm,random-v1
*YL ibm,random-v1
*FC
*DS ibm,sym-encryption-v1
*AX ibm,sym-encryption-v1
*YL ibm,sym-encryption-v1
*FC
*DS Obsidian-E PCI-E SCSI controller (14100a03)
*AX 0000:80:00.0
*AX pci1014,0339
*MF IBM
*TM PCIe 3Gb SAS RAID Adapter (574E)
*CD 1014030a
*YC 1
*YL U78AB.001.WZSJKJV-P1-T9
*FC
*AX host0
*XL host0
*YL U78AB.001.WZSJKJV-P1-T9
*FC
*AX 0:0:8:0
*AX sda
*MF IBM
*XH 0
*XB 0
*XT 8
*XL 0
*YL U78AB.001.WZSJKJV-P1-T9-B0-T8-L0
[...]
--

some visual separation between stanzas would help:
--
*VC 5.0
*TM IBM,8246-L2T
*SE IBM,03060606A
*PI IBM,03060606A
*OS Linux 3.10.0-229.el7.ppc64
*FC
*DS System VPD
*RT VSYS
*FG XXSV
*BR S0
*YL U8246.L2T.060606A
*SE 060606A
*TM 8246-L2T
*SU 0004AC194FE8
*VK ipzSeries
*YL U8246.L2T.060606A
*WN C0507606907D
*FV AL770_038

*FC
*DS ibm,compression-v1
*AX ibm,compression-v1
*YL ibm,compression-v1

*FC
*DS ibm,random-v1
*AX ibm,random-v1
*YL ibm,random-v1

*FC
*DS ibm,sym-encryption-v1
*AX ibm,sym-encryption-v1
*YL ibm,sym-encryption-v1

*FC
*DS Obsidian-E PCI-E SCSI controller (14100a03)
*AX 0000:80:00.0
*AX pci1014,0339
*MF IBM
*TM PCIe 3Gb SAS RAID Adapter (574E)
*CD 1014030a
*YC 1
*YL U78AB.001.WZSJKJV-P1-T9

*FC
*AX host0
*XL host0
*YL U78AB.001.WZSJKJV-P1-T9

*FC
*AX 0:0:8:0
*AX sda
*MF IBM
*XH 0
*XB 0
*XT 8
*XL 0
*YL U78AB.001.WZSJKJV-P1-T9-B0-T8-L0
[...]
--

Signed-off-by: Paul A. Clarke <[email protected]>

diff --git a/src/output/lsvpd.cpp b/src/output/lsvpd.cpp
index 588f66b..b6aef4e 100644
--- a/src/output/lsvpd.cpp
+++ b/src/output/lsvpd.cpp
@@ -155,6 +155,7 @@ void printVPD( Component* root )

  		if ( devName == "" || (devName != "" && devFound == true ) )
  		{
+			cout << endl;
  			cout << "*" << root->getFeatureCodeAC( ) << " ";
  			if( markedVpd && root->getFeatureCode( ) == "")
  				cout << "********";
--
Regards,
PC


------------------------------------------------------------------------------