Re: [PATCH 2/3] lpd: marvell: handle non-unique/duplicate location codes

Vasant Hegde <[email protected]> Tue, 8 Nov 2016 16:32:33 +0530
Newsgroups gmane.linux.tools.diag.devel
Message-ID <[email protected]>
On 10/21/2016 07:31 PM, Mauricio Faria de Oliveira wrote:
> On some systems, it's been observed that different disks of the Marvell
> SATA HDD controller might be listed with the very same location code.

IIUC each disk is an independent FRU. Just wondering why we may endup have same 
loc code for multiple disks.

>
> This could cause an user to specify a device by location code, and have
> the wrong device identified; if the service operation is a hotplug/pull
> the disk, that error would cause serious problems.
>
> Even though this might be a problem that requires a fix elsewhere, it's

I'd prefer to fix at the source (avoid duplicate loc code) instead of having 
workaround. But given the implications, I'm ok to accept this patch.

But who is creating these dup location codes? lsvpd tools or sysfs (kernel/DT) ?

-Vasant


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi