Re: [PATCH 1/3] lpd: Add support for Marvell HDD LEDs on S822LC for HPC

On 11/08/2016 10:11 PM, Mauricio Faria de Oliveira wrote:
> On 11/08/2016 11:05 AM, Mauricio Faria de Oliveira wrote:
>>> We have "LPD_DEBUG" for debug lpd code. Why not use same macro here?
>>
>> Yes, I see. I had build problems w/ the original code & LPD_DEBUG iirc
>> (not sure if I had set it correctly though; could you demonstrate it?)
>
> Hey, nevermind. I can't explain. Now it works.

Cool :-)

>
> $ make CFLAGS='-DLPD_DEBUG'
>
> The point I don't like is that this is a compile time change.  If one
> wants to change the behavior at runtime (get debug messages), it's not
> possible.
>
> I can change _dbg() to consider both the compile time flag and runtime
> env var.  If it's set at build time, always print the debug messages,
> and if it's not set an build time, but the env var is set at runtime,
> then print debug messages too.
>
> I'll submit a v3 of this patch only with this change, if you like
> that approach.

That's better. Lets not have multiple DEBUG macro for same codebase..

Well, ideally I'd prefer single DEBUG option for entire code base.. But 
unfortunately we endup having multiple DEBUG option.. I blame myself for adding 
new one for LPD code.. :-(

-Vasant


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi