Re: [PATCH v3 0/3] Support for Marvell SATA HDD LEDs on IBM Power System S822LC for HPC

On 11/09/2016 06:14 PM, Mauricio Faria de Oliveira wrote:
> This patch-set introduces support for the identification/fault LEDs of the
> Marvell SATA HDD controller present in the IBM Power System S822LC for HPC
> (a.k.a. Garrison/Minsky).
>
> Patch 1/3 implements the 'indicator' interface required by lpd/usysident.
> Patch 2/3 introduces one quirk for non-unique location code on the disks.
> Patch 3/3 guarantees the usysident program runs without kernel LEDs when
>            there is Marvell HDD LEDs available.
>

Overall patchset looks good.. Had few minor issues which I've fixed locally. We 
still have few issues to fix.. Since I forgot to mention this in previous 
iteration and also it can come as separate patch, I've merged this patchset.


- opal_get_indicator_mode()
   We need to add check in this function.

- opal_get_indicator_list()
   It worked today because we had sysfs leds on system. May be we should fix 
this function continue even though we fail  to get led list from sysfs led class.

-Vasant


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi