Re: [PATCH v3 0/3] Support for Marvell SATA HDD LEDs on IBM Power System S822LC for HPC

On 11/21/2016 08:35 AM, Vasant Hegde wrote:
> On 11/18/2016 04:30 AM, Mauricio Faria de Oliveira wrote:
>> Sorry; even w/ your explanation I didn't get why/what exactly
>> needs to be fixed in this function. Can you say it for dummies?
>
> Don't worry.. I will fix it.

Thanks a bunch.

>>> On error scandir returns -1 right?
>>
>> Yes, but is doesn't error in this case. The /sys/class/leds dir is
>> present even without LED modules loaded (led-class.o is built-in.)
>
>
> I was talking about the scenario where kernel won't create sysfs node.
> Probably we don't need to worry about this case for now.

Ok.

>> Would you please check if the assumption to remove the fault mode check
>> is correct? I'm afraid I don't understand enough about this to be sure.
>
> I've tweaked your patch slightly and merged it.

Cool. Thanks again for all your help!


-- 
Mauricio Faria de Oliveira
IBM Linux Technology Center


------------------------------------------------------------------------------