Re: [PATCH 3/3] m68knommu: Add ethernet driver forMCF547x/MCF548x
Philippe De Muyter <[email protected]>
| Newsgroups | gmane.linux.uclinux.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Sep 26, 2012 at 01:23:21AM +0200, Stany MARCEL wrote: > Helo, > > Flushing all caches for each sent frame might not be a good solution. I think that performances will be very bad. I'll look at this point in my tests. > > It might be more interesting to use caches in write through mode, or forcing theses explicit data out of cache. I (and the default for M54xx) use the write through mode. Philippe > > If kmalloc with GFP_DMA returns data that is not write cached (ideally SRAM for performances) there is no need to flush caches. > > Regards, > > > -----Original Message----- > From: Philippe De Muyter [mailto:[email protected]] > Sent: Tue 9/25/2012 10:34 PM > To: Stany MARCEL > Cc: [email protected] > Subject: Re: [uClinux-dev] [PATCH 3/3] m68knommu: Add ethernet driver forMCF547x/MCF548x > > On Tue, Sep 25, 2012 at 10:20:07PM +0200, Philippe De Muyter wrote: > > > > You should rather use 'mcf_cache_push'. > > I should have written: > > You should rather use '__flush_cache_all' > > And that should probably go in arch/m68k/include/asm/cacheflush_mm.h, > as long as arch/m68k/include/asm/cacheflush_mm.h and > arch/m68k/include/asm/cacheflush_no.h are separate files. > > Philippe -- Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev