Re: [PATCH] MC68328 platform code fix
Larry Baker <[email protected]>
| Newsgroups | gmane.linux.uclinux.devel |
|---|---|
| Message-ID | <[email protected]> |
Steve, I see several typos being fixed: "SPIM _IRQ_NUM" -> "SPIM_IRQ_NUM", i.e., there is a misplaced space in the defined constant identifier. Larry Baker US Geological Survey 650-329-5608 [email protected] On 20 Feb 2013, at 4:02 PM, Steve deRosier wrote: > Hey Luis, > > Maybe I'm confused, but in addition to the real changes, I'm seeing > quite a few things that I think are white space changes: > >> */ >> -#define IMR_MSPIM (1 << SPIM _IRQ_NUM) /* Mask SPI Master interrupt */ >> +#define IMR_MSPIM (1 << SPIM_IRQ_NUM) /* Mask SPI Master interrupt */ >> #define IMR_MTMR2 (1 << TMR2_IRQ_NUM) /* Mask Timer 2 interrupt */ > > I'm guessing that people will ask you to filter those out of your > functional commit before allowing the patches. > > - Steve > _______________________________________________ > uClinux-dev mailing list > [email protected] > http://mailman.uclinux.org/mailman/listinfo/uclinux-dev > This message was resent by [email protected] > To unsubscribe see: > http://mailman.uclinux.org/mailman/options/uclinux-dev _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev