Re: M5282 Coldfire & I2C
Greg Ungerer <[email protected]>
| Newsgroups | gmane.linux.uclinux.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Steven, On 10/07/14 05:42, Steven King wrote: > On Wednesday 09 July 2014 6:35:03 am Greg Ungerer wrote: >> Hi Steven, >> >> The ColdFire platform parts look ok to me. I would like to apply them >> to the m68knommu git tree. Can I have your signed-off-by for that part? >> They don't apply cleanly to the for-next branch, due to clashes with >> recent qspi changes, but the fixup is simple. >> >> The drivers/i2c/busses changes will need to go via >> [email protected] > > Alas, therein lies the rub; the folks over at [email protected] felt > that since the coldfire i2c is similar to the imx i2c, the existing imx i2c > driver should be used instead of adding another driver to the tree. So I've > given up on getting this merged and thats why I didnt post this as a patch > with all the sign-offs and whatnot. Ok, understand. Do you see any value then in having the platform specific parts merged still then? I like that it adds the clocks and other base definitions for i2c. But it its probably not a good idea to have code conditional on a define that cannot ever be set in tree. Regards Greg _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev