Re: qemu/m68k
Greg Ungerer <[email protected]>
| Newsgroups | gmane.linux.uclinux.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Geert, On 22/08/14 17:12, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Aug 22, 2014 at 2:40 AM, Greg Ungerer <[email protected]> wrote: >>>>> qemu: hardware error: mcf_fec_read: Bad address 0x1c4 >>>> >>>> Hmmm, yeah, it does stop there. Not sure why. I will need to look >>>> more closely at that. >>> >>> Did you found anything? >> Yep. The problem is that the FEC driver is writing to registers >> that don't exist in the FEC hardware module on the ColdFire >> family. Support for some of the extended registers used on >> the FEC are used on ARM implementations, and they had added >> support for those in more recent years. >> >> I never picked those up on real hardware. Accesses to those >> on addresses cause no (visible) problems. >> >> Anyway, attached is a patch I propose to fix it. I will be >> sending this to the linux net-dev list soon. > Instead of sprinkling the driver with (more) #ifdefs, wouldn't it be > better to use FEC_QUIRK_* flags in fec_devtype / platform data? This patch only added one more #ifdef... But your right, it would be nice to have a lot less. I'll take another look at this. Thanks Greg _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev