Re: [PATCH] m68k: Add missing ioport_unmap()

Hi Geert,

On 15/09/14 17:36, Geert Uytterhoeven wrote:
> On Mon, Sep 15, 2014 at 3:07 AM, Greg Ungerer <[email protected]> wrote:
>> On 14/09/14 19:45, Geert Uytterhoeven wrote:
>>> drivers/net/ethernet/cirrus/cs89x0.c: In function ‘cs89x0_ioport_probe’:
>>> drivers/net/ethernet/cirrus/cs89x0.c:1629: error: implicit declaration of function ‘ioport_unmap’
>>>
>>> Add the missing ioport_unmap() implementation, and convert ioport_map()
>>> from a macro to a static inline function while we're at it (both copied
>>> from asm-generic).
>>
>> The non-mmu version of this, io_no.h, doesn't implement these either.
>> Should it?
> 
> I think it should. However, you probably can't get there without PCI or ISA
> enabled.
> 
> (doing some experiments with M548x/allmodconfig builds)
> 
> Currently PCI on M54xx is limited to MMU=y?

Yes, though I am not sure why we have it limited to that case.


> As soon as PCI can be enabled with MMU=n, you can get to:
> 
> lib/pci_iomap.c: In function ‘pci_iomap’:
> lib/pci_iomap.c:37: error: implicit declaration of function ‘ioport_map’
> lib/pci_iomap.c:37: warning: return makes pointer from integer without a cast
> 
> drivers/gpio/gpio-amd8111.c: In function ‘amd_gpio_init’:
> drivers/gpio/gpio-amd8111.c:215: error: implicit declaration of
> function ‘ioport_map’
> drivers/gpio/gpio-amd8111.c:215: warning: assignment makes pointer
> from integer without a cast
> drivers/gpio/gpio-amd8111.c: In function ‘amd_gpio_exit’:
> drivers/gpio/gpio-amd8111.c:236: error: implicit declaration of
> function ‘ioport_unmap’

Ok, I say yes we need it for non-MMU too. Do you want to come up with
another patch for the non-MMU case, or do you want me to do it?

Regards
Greg




_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev