Re: [PATCH] m68knommu: Fix typos in Coldfire 5272 DMA debug code

Hi Greg,

On Fri, Feb 10, 2017 at 1:50 PM, Greg Ungerer <[email protected]> wrote:
> On 09/02/17 22:44, Geert Uytterhoeven wrote:
>> If DEBUG_DMA is defined:
>>
>>     include/asm/dma.h: In function ‘set_dma_mode’:
>>     include/asm/dma.h:392: error: ‘dmabp’ undeclared (first use in this
>> function)
>>     include/asm/dma.h:392: error: (Each undeclared identifier is reported
>> only once
>>     include/asm/dma.h:392: error: for each function it appears in.)
>>     include/asm/dma.h: In function ‘set_dma_addr’:
>>     include/asm/dma.h:423: error: ‘dmawp’ undeclared (first use in this
>> function)
>>
>> Reported-by: kbuild test robot <[email protected]>
>> Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> Acked-by: Greg Ungerer <[email protected]>
>
> Ultimately I think that all the DEBUG_DMA could just be removed.
> There is only 4 cases of it, and it doesn't look particularly
> useful as-is.

I reworked it as part of "m68k/coldfire: Modernize printing of kernel
messages", but that needs an update for the received review comments.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev