Re: [PATCH] m68knommu: remove set_fs()

Linus Torvalds <[email protected]> Tue, 6 Jul 2021 11:36:26 -0700

Newsgroups	gmane.linux.ports.m68k,gmane.linux.uclinux.devel
Message-ID	<CAHk-=wjZRs8icwmK4g-XSmY7PB9WUhi3=KGs5NsV7QO=uW_taw@mail.gmail.com>

On Mon, Jul 5, 2021 at 9:13 PM Christoph Hellwig <[email protected]> wrote:
>
> It still needs "real" kernel-style set_fs for the mm/maccess.c routines,
> but adding __{get,put}_kernel_nofault should not be too hard.

Yeah, it's not that it wants set-fs(), it's that I missed that m68k
doesn't have HAVE_GET_KERNEL_NOFAULT.

Implementing __get/put_kernel_nofault() should be fairly
straightforward: they are basically the same thing as the
__get/put_user() functions, except they should just use "move" instead
of "moves".

The m68k uaccess.h file already kind of has support for that, but it's
hardcoded to the CONFIG_CPU_HAS_ADDRESS_SPACES config, rather than
being available as two different versions.

           Linus