[umbrello] [Bug 56184] Support loading of foreign XMI file formats

https://bugs.kde.org/show_bug.cgi?id=56184

--- Comment #100 from Oliver Kellogg <[email protected]> ---
Git commit c9da2ac42873122be610cdf2ae6a004f591e0623 by Oliver Kellogg.
Committed on 12/01/2022 at 20:16.
Pushed by okellogg into branch 'master'.

Followup to commit dba3b12 - further preparation for loading files from
https://www.eclipse.org/papyrus

umbrello/umlmodel/attribute.cpp
- In function load1 case m_SecondaryId.isEmpty() while-loop, if href is
  non empty then require href to contain "PrimitiveTypes" in addition to
  "#".  Reason: Papyrus concidentally uses the datatype name as the
  xmi:id, but only in the predefined UMLPrimitiveTypes.library.uml and
  JavaPrimitiveTypes.library.uml.
  Proper resolution of href would require nested loading of model files,
  which is not yet implemented for Papyrus.

umbrello/dialogs/codetexthighlighter.cpp
- In function keywords() return empty QStringList immediately if `pl' is
  `Reserved' (else we crash due to null pointer dereference).

umbrello/codegenerators/codegenfactory.cpp
- In function createObject return null immediately if `pl' is Reserved
  (else we crash due to null pointer dereference).

M  +2    -0    umbrello/codegenerators/codegenfactory.cpp
M  +4    -1    umbrello/dialogs/codetexthighlighter.cpp
M  +6    -4    umbrello/umlmodel/attribute.cpp

https://invent.kde.org/sdk/umbrello/commit/c9da2ac42873122be610cdf2ae6a004f591e0623

-- 
You are receiving this mail because:
You are the assignee for the bug.