[umbrello] [Bug 449297] Code import wizard: python wrong function return

https://bugs.kde.org/show_bug.cgi?id=449297

Oliver Kellogg <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.33.80 (KDE releases
                   |                            |22.03.80)
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/126264fdacc
                   |                            |53e6d209258115a5d977a1ac3c8
                   |                            |2e

--- Comment #1 from Oliver Kellogg <[email protected]> ---
Git commit 126264fdacc53e6d209258115a5d977a1ac3c82e by Oliver Kellogg.
Committed on 31/01/2022 at 20:57.
Pushed by okellogg into branch 'master'.

Fix "Code import wizard: python wrong function return"

umbrello/codeimport/pythonimport.{h,cpp}
- At function skipBody add optional argument foundReturn of type bool*.
  If given then the variable pointed to will be set true if a 'return'
  statement was encountered while skipping.
  If no 'return' statement was encountered then the variable will be set
  to false.
- In function parseStmt() handling of keyword "def" :
  - Move local srcIndex and call to op->setSourceCode to before the call
    to Import_Utils::insertMethod.
  - Define local foundReturn of type bool.
  - Define local QString bodyCode initialized to skipBody(&foundReturn).
  - Define local QString returnTypeName which is left empty if
    foundReturn is returned false and is set to "string" if foundReturn
    is returned true.
  - At call to Import_Utils::insertMethod provide returnTypeName as the
    return type argument.
  - At call to op->setSourceCode provide bodyCode as argument.
FIXED-IN:2.33.80 (KDE releases 22.03.80)

M  +18   -4    umbrello/codeimport/pythonimport.cpp
M  +1    -1    umbrello/codeimport/pythonimport.h

https://invent.kde.org/sdk/umbrello/commit/126264fdacc53e6d209258115a5d977a1ac3c82e

-- 
You are receiving this mail because:
You are the assignee for the bug.