Re: Re: [PATCH v2 0/3] Inline helpers into Rust without full LTO
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.kbuild.devel,gmane.linux.kernel.mm,gmane.linux.kernel.rust |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Mar 22, 2026 at 08:38:30PM +0100, Miguel Ojeda wrote:
> - The docs on `regulator_get()` don't say it may return `NULL`. It
> originally that case, but commit be1a50d4eba4 ("regulator: Let
> drivers know when they use the stub API") changed that without
> changing the docs.
Callers should never treat NULL any differently to any other non-error
pointer, this is not a value intended for inspection by users.
> The original sentence (which still is there) says that nothing
> should look at the value, but then it goes onto say that drivers may
> actually look at the value.
Having specific handling for NULLs is very much not a preferred
interface, and most things shouldn't. The caller should probably have
it's own !CONFIG_REGULATOR checks rather than using the return value.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmnBRgsACgkQJNaLcl1U h9C71gf9GpM/jjG7XngTH0kbbP53phsB1+ihdqiu8gRSA2NkhE0CDNEtrjeo8HK+ YFX9N3jSxdG8Xb07O5JUW+IXTMGCeLvz1uSBXZdXIabxC9f1LMtKTabWh0ZHf713 HWaiw2tyL04gxzoGRUMOxAdjtJO/AHPk+s6yJ/mQq30LL2Ct3q4SD2EtDeCiBi24 uVumpIb9BMTfIXF2ygQqJYC2bsstGVbR9LCepYNRWzl6pJ+8qpCwRMNb90/Fc54c L2PQmhNC1Q8X3ghZTF3R48f7nMOug5EndZ2txdR3Z3qvY7xacpJH5R55yoodXcVg aFFTXPyWGRpSqwmfdF6DFkUEV7QZAQ== =T4pk -----END PGP SIGNATURE-----