Re: [PATCH v2 0/3] Inline helpers into Rust without full LTO
Christian Schrefl <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.ports.arm.kernel,gmane.linux.kbuild.devel,gmane.linux.kernel,gmane.linux.kernel.mm,gmane.linux.kernel.rust |
|---|---|
| Message-ID | <[email protected]> |
Hi Miguel, On 3/26/26 2:47 PM, Miguel Ojeda wrote: > On Thu, Mar 26, 2026 at 11:10 AM Alice Ryhl <[email protected]> wrote: >> >> I noticed that the Makefile currently uses the arm-unknown-linux-gnueabi >> target. It should probably not be -linux target to avoid this? Probably >> it should just be armv7a-none-eabi, right? We gate HAVE_RUST on >> CPU_32v7, so we should not need to consider the other variants. > > I think Christian tried several targets back then and eventually > picked that one. > > Christian: what was the reason to pick the `-linux-` one? e.g. was > there something you wanted to rely on that target spec that you > couldn't enable or disable via `rustc` flags or similar? It should probably be fine to use armv7a-none-eabi. I've mostly used arm-unknown-linux-gnueabi since I though it needed to match the bindgen-target (which is -linux-gnu for all architectures) and because from what I understand clang also uses arm-linux-gnueabi [1]. Also when I selected the target I thought that we would also support armv6, but since I had no v6 hardware to test on I disabled it. [1]: https://github.com/Rust-for-Linux/linux/blob/rust-next/scripts/Makefile.clang#L4 Cheers, Christian