Re: [RFC PATCH v1 2/9] uaccess: Convert INLINE_COPY_{TO/FROM}_USER to kconfig and reduce ifdefery
Andrew Cooper <[email protected]>
| Newsgroups | gmane.linux.ports.hexagon,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.comp.emulators.kvm.devel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.efi,gmane.comp.freedesktop.amd-gfx,gmane.comp.video.dri.devel,gmane.comp.freedesktop.xorg.drivers.intel,gmane.linux.network,gmane.linux.kernel.wireless.general,gmane.linux.kernel.spi.devel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.serial,gmane.linux.usb.general,gmane.comp.emulators.xen.devel,gmane.linux.file-systems,gmane.linux.kernel.bpf,gmane.linux.kernel.mm,gmane.linux.x25,gmane.linux.kernel.rust,gmane.linux.sound,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.kernel.cross-arch |
|---|---|
| Message-ID | <[email protected]> |
On 27/04/2026 9:47 pm, Yury Norov wrote: > On Mon, Apr 27, 2026 at 09:39:33PM +0100, Andrew Cooper wrote: >> On 27/04/2026 7:39 pm, Yury Norov wrote: >>> On Mon, Apr 27, 2026 at 07:13:43PM +0200, Christophe Leroy (CS GROUP) wrote: >>>> Among the 21 architectures supported by the kernel, 16 define both >>>> INLINE_COPY_TO_USER and INLINE_COPY_FROM_USER while the 5 other ones >>>> don't define any of the two. >>>> >>>> To simplify and reduce risk of mistakes, convert them to a single >>>> kconfig item named CONFIG_ARCH_WANTS_NOINLINE_COPY which will be >>> We've got a special word for it: outline. Can you name it >>> CONFIG_OUTLINE_USERCOPY, or similar? >> You can't swap the "in" for "out" like this. "out of line" is the >> opposite of "inline" in this context, while "outline" means something >> different and unrelated. > Check KASAN_OUTLINE vs KASAN_INLINE for example Then I suggest it gets corrected before more examples try to copy this non-english. ~Andrew