Re: [PATCH 04/11] treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS
SeongJae Park <[email protected]>
| Newsgroups | gmane.linux.kernel.cross-arch,gmane.comp.emulators.kvm.devel,gmane.linux.kernel.modules,gmane.linux.kernel.mm,gmane.comp.security.apparmor,gmane.linux.kernel.lsm,gmane.linux.uml.devel,gmane.linux.acpi.devel,gmane.linux.kernel.openipmi,gmane.comp.emulators.qemu,gmane.comp.freedesktop.xorg.drivers.intel,gmane.comp.video.dri.devel,gmane.linux.drivers.rdma,gmane.linux.drivers.video-input-infrastructure,gmane.linux.kernel.pci,gmane.linux.scsi,gmane.linux.power-management.general,gmane.linux.ports.ppc64.devel,gmane.linux.serial,gmane.linux.usb.general,gmane.linux.kernel,gmane.linux.network,gmane.linux.file-systems |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 21 May 2026 06:33:17 -0700 Kees Cook <[email protected]> wrote: > Using Coccinelle, rewrite every struct kernel_param_ops initializer that > sets .get into a DEFINE_KERNEL_PARAM_OPS-family macro invocation, > for example: > > @@ > declarer name DEFINE_KERNEL_PARAM_OPS; > identifier OPS; > expression SET, GET; > @@ > - const struct kernel_param_ops OPS = { > - .set = SET, > - .get = GET, > - }; > + DEFINE_KERNEL_PARAM_OPS(OPS, SET, GET); > > Using the macro for initialization means future changes can manipulate > the struct layout and callback prototypes without having to change every > initializer. > > Signed-off-by: Kees Cook <[email protected]> > --- [...] > mm/damon/lru_sort.c | 19 ++--- > mm/damon/reclaim.c | 19 ++--- > mm/damon/stat.c | 6 +- [...] > samples/damon/mtier.c | 6 +- > samples/damon/prcl.c | 6 +- > samples/damon/wsse.c | 6 +- For the above DAMON part changes, Reviewed-by: SeongJae Park <[email protected]> Thanks, SJ [...]