Re: [RFC V2 5/6] sh/mm: Stop using pgd_ERROR()
"David Hildenbrand (Arm)" <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kernel.mm,gmane.linux.ports.alpha,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.cross-arch,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/26 06:21, Anshuman Khandual wrote: > Stop using pgd_ERROR() in __get_pte_phys() when page table entry is already > known to be empty. > > Cc: Yoshinori Sato <[email protected]> > Cc: Rich Felker <[email protected]> > Cc: John Paul Adrian Glaubitz <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Anshuman Khandual <[email protected]> > --- > arch/sh/mm/init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index 0bb8555568a4..585012293632 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -52,10 +52,8 @@ static pte_t *__get_pte_phys(unsigned long addr) > pmd_t *pmd; > > pgd = pgd_offset_k(addr); > - if (pgd_none(*pgd)) { > - pgd_ERROR(*pgd); > + if (pgd_none(*pgd)) > return NULL; > - } > > p4d = p4d_alloc(NULL, pgd, addr); > if (unlikely(!p4d)) Reviewed-by: David Hildenbrand (Arm) <[email protected]> -- Cheers, David