Re: [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()

Thanks,

I guess I missed that one.

A.


On 09/12/17 11:49, Dan Carpenter wrote:
> We need to unlock and restore IRQs on this error path.
>
> Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index d1d53015d572..bb83a2d22ac2 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev)
>  	struct vector_device *vdevice;
>  
>  	spin_lock_irqsave(&vp->lock, flags);
> -	if (vp->opened)
> +	if (vp->opened) {
> +		spin_unlock_irqrestore(&vp->lock, flags);
>  		return -ENXIO;
> +	}
>  	vp->opened = true;
>  	spin_unlock_irqrestore(&vp->lock, flags);
>  
>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html