Re: [PATCH] Extract initrd free logic from arch-specific code.

--===============2477001509995621341==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Hi Rob,

Rob Landley <[email protected]> writes:

> On 03/28/2018 10:26 AM, Shea Levy wrote:
>> Now only those architectures that have custom initrd free requirements
>> need to define free_initrd_mem.
> ...
>> --- a/arch/arc/mm/init.c
>> +++ b/arch/arc/mm/init.c
>> @@ -229,10 +229,3 @@ void __ref free_initmem(void)
>>  {
>>  	free_initmem_default(-1);
>>  }
>> -
>> -#ifdef CONFIG_BLK_DEV_INITRD
>> -void __init free_initrd_mem(unsigned long start, unsigned long end)
>> -{
>> -	free_reserved_area((void *)start, (void *)end, -1, "initrd");
>> -}
>> -#endif
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 3f972e83909b..19d1c5594e2d 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -47,6 +47,7 @@ config ARM
>>  	select HARDIRQS_SW_RESEND
>>  	select HAVE_ARCH_AUDITSYSCALL if (AEABI && !OABI_COMPAT)
>>  	select HAVE_ARCH_BITREVERSE if (CPU_32v7M || CPU_32v7) && !CPU_32v6
>> +	select HAVE_ARCH_FREE_INITRD_MEM
>>  	select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU
>>  	select HAVE_ARCH_KGDB if !CPU_ENDIAN_BE32 && MMU
>>  	select HAVE_ARCH_MMAP_RND_BITS if MMU
>
> Isn't this why weak symbols were invented?
>

This approach was suggested by Christoph Hellwig upthread, and seems to
have some precedent elsewhere (e.g. strncasecmp), but I agree weak
symbols seem appropriate here. I'm happy to implement either approach!

>
> Confused,
>
> Rob

Thanks,
Shea

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE6ESKvwKkwnxgMLnaXAvWlX2G/icFAlq7vPwACgkQXAvWlX2G
/if+nw/+PoGVROmqDrZBJgIrBQ4iqr8JYstaRZvlA9dxV21BXbFQka8L1+cd8ma5
7PvtjL4EfGGPxzNYBJVXzz7LjbkJp4IGDWTRhm5kuh7bFP9l3MmYd1OQhXAzd94b
ZbqvNz9A/fM1I0cg0adEqHJi9cJtiAU/wS8cloZtdRHL9QCQPqIe6tCglj/8tFK1
f0iG7gGakfrJzlxgY+Jd/RYUKaDLQoFlgjcVf7CI+Qro8U0zOTWdl9x1ifEXYMK6
XBo9bPSVAeFEE8Du+JHUpKdoachX5nWjo9qpFpfLMu9n3fFKx8rVChTvaSxd8U36
BF5rJNaZwLweNIovJMrjcYEkqIgVTKyoGqt5mbrypDk+3YTFpMmtW5WjHiSLEwDz
/RPjwiNMEjBwDIGSEDg+5ZHFe3XqnV4x3QBzzvZmHNhs4EosiAqmoKXRr8Y3T1qB
lyNp1R4KcxNr9ZfHrTQhbw3djEwOVsTLfqw7jTFwiklzTOrCiMSL0ZuwsXEIeZuK
3APYuKe7kpJ4A4M96puGy+R65sJOY3ivyo9j/RGryDjhybXGbGHqW8hBYFWFzBv0
ceBFwd71TWrTq8wWhVNgqCgLomfjovL2VfwmRsVXDTGRqcD5jRRc6fnGcR+97Dpa
86p3i5woQCxRbtzT8Kt4BfFGit8lP5SDC06EnGj/0KaULzdxZI0=
=UTNs
-----END PGP SIGNATURE-----
--=-=-=--


--===============2477001509995621341==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
--===============2477001509995621341==--