Re: [PATCH] Extract initrd free logic from arch-specific code.

Wei Yang <[email protected]> Thu, 29 Mar 2018 09:12:10 +0800

Newsgroups	gmane.linux.kernel.arc,gmane.linux.ports.mips.general,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.linux.ports.ia64,gmane.linux.ports.hexagon,gmane.linux.kernel.metag,gmane.linux.ports.arm.kernel,gmane.linux.ports.parisc,gmane.linux.ports.alpha,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.uml.user,gmane.linux.ports.ppc64.devel
Message-ID	<[email protected]>

On Wed, Mar 28, 2018 at 09:55:07AM -0700, Kees Cook wrote:
>On Wed, Mar 28, 2018 at 8:26 AM, Shea Levy <[email protected]> wrote:
>> Now only those architectures that have custom initrd free requirements
>> need to define free_initrd_mem.
>>
>> Signed-off-by: Shea Levy <[email protected]>
>
>Yay consolidation! :)
>
>> --- a/usr/Kconfig
>> +++ b/usr/Kconfig
>> @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION
>>         default ".lzma" if RD_LZMA
>>         default ".bz2"  if RD_BZIP2
>>         default ""
>> +
>> +config HAVE_ARCH_FREE_INITRD_MEM
>> +       bool
>> +       default n
>
>If you keep the Kconfig, you can leave off "default n", and I'd
>suggest adding a help section just to describe what the per-arch
>responsibilities are when select-ing the config. (See
>HAVE_ARCH_SECCOMP_FILTER for an example.)
>

One question about this change.

The original code would "select" HAVE_ARCH_FREE_INITRD_MEM on those arch.
After this change, we need to manually "select" this?

>-Kees
>
>-- 
>Kees Cook
>Pixel Security

-- 
Wei Yang
Help you, Help me