Re: 2.6.20-rc6 pb_fnmode regression

On Mon, 29 Jan 2007, Soeren Sonnenburg wrote:

> Well I need in-kernel usbhid and the way this was implemented in 2.6.19 
> (and before) one could change pb_fnmode on-the-fly. This is mentioned in 
> all the power/i/mac/book tutorials and everyone is used to switching 
> modes this way. I can happily patch the kernel to use the pb_fnmode but 
> nonetheless this is a regression to pre 2.6.20* and will confuse others 
> too...

Ah, now I see. The problem is that in pre-2.6.20-rc1 the pb_fnmode was 
setting global variable, but after the HID layer rework, this is a per-hid 
variable, which is of course not updated when write to sysfs triggers.

I will try to fix this before I send 2.6.20-rc6 updates to Linus, thanks 
for pointing this out.

-- 
Jiri Kosina