Re: PATCH: usb: descriptor structures have to be packed
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Novell |
| Message-ID | <[email protected]> |
Am Dienstag, 6. Februar 2007 23:48 schrieb Pete Zaitcev: > On Tue, 6 Feb 2007 13:08:19 -0800, Inaky Perez-Gonzalez <[email protected]> wrote: > > > [btw, I truly have little idea about which are those specific costs, > > out of professional curiosity, got any pointers?] > > http://www.digitalvampire.org/blog/articles/2006/07/31/why-you-shouldnt-use-__attribute__-packed > > This is only an example though, and depending on the situation you might > want to trade traps for bloat or vice versa. I am not against using > the packed attribute, I'm against using it without thinking. > > > How do suggest we tackle this issue? > > I would access by byte. But keep doing what you're doing. It's a David's > code, and Itanium is dead like a stone anyway. I only want you to know > that __attribute((__packed__)) is hardly superior to the old style which > worked fine for a 1000 years before gcc. This means throwing away the type information. What we are accessing isn't a stream of bytes, it is a structured object of defined endianness. Regards Oliver ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel