Re: [PATCH 1/2] USB: add Freescale high-speed USB SOC device controller driver

> >>> +static int fsl_udc_suspend(struct platform_device *pdev,
> > pm_message_t state);
> >>> +static int fsl_udc_resume(struct platform_device *pdev);
> >>> +static void fsl_ep_fifo_flush(struct usb_ep *_ep);
> >>> +
> >>> +#ifdef CONFIG_PPC32
> >>
> >> Any reason we need to protect these with CONFIG_PPC32?
> >>
> >>> +#undef	NO_SNOOPING
> >>> +#define fsl_readl(addr)		in_le32(addr)
> >>> +#define fsl_writel(addr, val32) out_le32(val32, addr)
> >>> +#endif
> >
> > For example, MX31 doesn't have the SNOOPING feature and will use
other
> > I/O accessors.
> 
> The snooping makes sense.  How are the accessors on MX31 different?

There isn't accessor like in_le32() for arm.  I'm not very sure but they
may prefer to use readl/writel?

- Leo

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel