Re: Blackberry driver and pm

Am Donnerstag, 8. Februar 2007 02:25 schrieb Greg KH:

> Or is this in relation to the autosuspend issues?

These exist, too. You've added the blackberry to the quirk list.
This is incorrect. For once, somebody might compile a kernel
without your driver. In this case disabling power management
is wrong.
Strictly speaking this issue should be left to user space, but if
you want to do it in kernel, here's the patch.

	Regards
		Oliver

Signed-off-by: Oliver Neukum <[email protected]>
----

--- a/drivers/usb/misc/berry_charge.c	2007-02-08 11:00:02.000000000 +0100
+++ b/drivers/usb/misc/berry_charge.c	2007-02-08 11:01:33.000000000 +0100
@@ -99,6 +99,8 @@
 	if ((udev->actconfig->desc.bMaxPower * 2) == 500) {
 		dbg(&udev->dev, "device is already charging, power is "
 		    "set to %dmA\n", udev->actconfig->desc.bMaxPower * 2);
+		/* but we make sure the device be not autosuspended */
+		usb_autopm_get_interface(intf);
 		return -ENODEV;
 	}
 
--- a/drivers/usb/core/quirks.c	2007-02-08 11:02:05.000000000 +0100
+++ b/drivers/usb/core/quirks.c	2007-02-08 11:02:19.000000000 +0100
@@ -37,9 +37,6 @@
 	/* Elsa MicroLink 56k (V.250) */
 	{ USB_DEVICE(0x05cc, 0x2267), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 
-	/* USB Blackberry devices */
-	{ USB_DEVICE(0x0fca, 0x0001), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
-
 	{ }  /* terminating entry must be last */
 };
 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel