Re: USB: make usb_iso_packet_descriptor.status signed

Alan Stern <[email protected]>
Newsgroups gmane.linux.usb.devel
Message-ID <[email protected]>
On Sun, 11 Feb 2007, Pete Zaitcev wrote:

> The status in usb_iso_packet_descriptor should be signed, for the benefit
> of someone who casts to a long or makes other benign misstep (the principle
> of least surprise).
> 
> Signed-off-by: Pete Zaitcev <[email protected]>
> 
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -935,7 +935,7 @@ struct usb_iso_packet_descriptor {
>  	unsigned int offset;
>  	unsigned int length;		/* expected length */
>  	unsigned int actual_length;
> -	unsigned int status;
> +	int status;
>  };
>  
>  struct urb;

Do we also want to update the corresponding userspace-visible declaration 
in usbdevice_fs.h?

Alan Stern


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.